Skip to content

WIP: display_format for style #11768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

WIP: display_format for style #11768

wants to merge 2 commits into from

Conversation

TomAugspurger
Copy link
Contributor

Unfinished at the moment. Just wanted to push something up since there are other PRs that could build on this.

This moves the logic of "what value should I display for this cell?" from the Template to the Styler class itself. The two biggest benefits are

  1. User extensibility: Users provide formatting functions (via an API that's TBD) which are called upon the data values when we translate.
  2. Maintainability: Instead of complex logic in the template, we have (slightly) less complex logic in the class itself.

@TomAugspurger TomAugspurger added IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string labels Dec 5, 2015
@TomAugspurger TomAugspurger added this to the 0.18.0 milestone Dec 5, 2015
@TomAugspurger TomAugspurger mentioned this pull request Dec 5, 2015
Closed
@TomAugspurger
Copy link
Contributor Author

Closing in favor of #11667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
IO HTML read_html, to_html, Styler.apply, Styler.applymap Output-Formatting __repr__ of pandas objects, to_string
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
1 participant
@TomAugspurger